…pr83

…irst try magento#21513

 - Merge Pull Request magento#21513 from shikhamis11/magento2:2.2-develop-PR-port-21335
 - Merged commits:
   1. 8493e59
   2. 65e9346

…to#21423

…ibute programmatically magento#21437

… be added twice magento#21383 - excluded tax from min price

…pr83

Good afternoon,

I just encountered a problem with product's tabs in product info.
I realized when description or other custom tabs have links, when you click on it, nothing happen.

It caused by the script mage/tabs.js in details.phtml.

The current link to trigger the tab is declared with data-role="switch" instead of a data-role="trigger".

https://github.com/magento/magento2/blob/4f232511ceba6f1f7bf6f73b3b5609bd087f8c74/app/code/Magento/Catalog/view/frontend/templates/product/view/details.phtml#L24-L37

When not even the trigger and the header is declared respectively by data-role="heading" and data-role="trigger", the script based it search on the current collapsible panel declared by data-role="collapsible".

https://github.com/magento/magento2/blob/4f232511ceba6f1f7bf6f73b3b5609bd087f8c74/lib/web/mage/tabs.js#L99-L124

You can simply try by adding a link in the product description.

Tell me if I am wrong.

Cheers,
Ilan PARMENTIER

Good afternoon,

I find out attribute aria-labelledby is misconfigured.
It must be declared for the content of the tab and not the title, in particular, for a parent tag.

Ilan PARMENTIER

Source :
https://www.w3.org/TR/wai-aria-practices/examples/tabs/tabs-1/tabs.html#sc1_label

…ue-19166

… for guests converted to customers after checkout. magento#21325

 - Merge Pull Request magento#21325 from Nazar65/magento2:backport-issue-19166
 - Merged commits:
   1. 9746716
   2. abcf202
   3. 80e5e39

 - Merge Pull Request magento#21531 from amol2jcommerce/magento2:2.2-develop-PR-port-20858
 - Merged commits:
   1. 13c6edd

…pr23

Accepted Public Pull Requests:
 - magento#21423: [Backport] Make the module list more deterministic (by @eduard13)
 - magento#21437: [Backport]-issue-195196 Can't upload customer Image attribute programmatically (by @Nazar65)


Fixed GitHub Issues:
 - magento#8479: Sequence of module load order should be deterministic (reported by @scottsb) has been fixed in magento#21423 by @eduard13 in 2.2-develop branch
   Related commits:
     1. abc3e7c
     2. 4b2c1b4
     3. 730987f

 - magento#16116: Modules sort order in config.php is being inconsistent when no changes being made (reported by @comdiler) has been fixed in magento#21423 by @eduard13 in 2.2-develop branch
   Related commits:
     1. abc3e7c
     2. 4b2c1b4
     3. 730987f

 - magento#19983: Can't work customer Image attribute programmatically (reported by @cygnetampatel) has been fixed in magento#21437 by @Nazar65 in 2.2-develop branch
   Related commits:
     1. b635e09
     2. 97b8f5f

…other Configurable product in the admin

…autoload magento#21435

 - Merge Pull Request magento#21435 from amol2jcommerce/magento2:2.2-develop-PR-port-20950
 - Merged commits:
   1. 2e58ab6
   2. 3de1647

Accepted Public Pull Requests:
 - magento#21838: [Backport] Fix magento#21648 Checkout Agreements checkbox missing asterisk (by @amol2jcommerce)


Fixed GitHub Issues:
 - magento#21648: Checkout Agreements checkbox missing asterisk (reported by @Karlasa) has been fixed in magento#21838 by @amol2jcommerce in 2.2-develop branch
   Related commits:
     1. 079ecb3
     2. 943fb33
     3. 745df9a
     4. 8c609c4

…o#21661

 - Merge Pull Request magento#21661 from Cyanoxide/magento2:2.2-develop
 - Merged commits:
   1. ec51033

…bp-20936

…or pending review magento#21849

 - Merge Pull Request magento#21849 from eduard13/magento2:2.2-develop-bp-20936
 - Merged commits:
   1. dd3a94a
   2. 5c8dba8
   3. 95c1bc8

…ntegration and unit tests magento#21859

 - Merge Pull Request magento#21859 from eduard13/magento2:2.2-develop-PR-port-21795
 - Merged commits:
   1. 229da15
   2. 89bcefa
   3. 0cd94e2
   4. afa9a80

…dditionalData

…label in getA… magento#21872

 - Merge Pull Request magento#21872 from mage2pratik/magento2:back-port-pull-20482
 - Merged commits:
   1. c4312eb

…cess file into pub/media folder magento#21037

Accepted Public Pull Requests:
 - magento#21037: [Backport] Added RewriteBase directive template in .htaccess file into pub/media folder (by @ccasciotti)

…kend indexers page after creating a custom index magento#21576

 - Merge Pull Request magento#21576 from ccasciotti/magento2:back-port-pull-21575
 - Merged commits:
   1. 2c956f6
   2. d5ed9e8

…label in getA… magento#21872

…ntegration and unit tests magento#21859

…autoload magento#21435

…or pending review magento#21849

Accepted Public Pull Requests:
 - magento#21872: [Backport] [TASK] Remove translation of attribute store label in getA� (by @mage2pratik)
 - magento#21859: [Backport] [Wishlist] Covering the Wishlist classes by integration and unit tests (by @eduard13)
 - magento#21435: [Backport] magento#20773: Do not throw exception during autoload (by @amol2jcommerce)
 - magento#21849: [Backport][Review] Fix Pending Reviews label, add menu for pending review (by @eduard13)


Fixed GitHub Issues:
 - magento#20773: The autoloader throws an exception on class_exists (reported by @sidolov) has been fixed in magento#21435 by @amol2jcommerce in 2.2-develop branch
   Related commits:
     1. 2e58ab6
     2. 3de1647

 - magento#20924: Reviews ACL issue - showing Reviews menu two times under System > User Roles > Add New Role > Role Resources (reported by @dankhrapiyush) has been fixed in magento#21849 by @eduard13 in 2.2-develop branch
   Related commits:
     1. dd3a94a
     2. 5c8dba8
     3. 95c1bc8

…kend indexers page after creating a custom index magento#21576

…o#21661

… tax magento#21845

Accepted Public Pull Requests:
 - magento#21576: [Backport] Fix for issue magento#21510: Can't access backend indexers page after creating a custom index (by @ccasciotti)
 - magento#21661: [backport] Improve swatch table overflow handling (by @Cyanoxide)
 - magento#21845: [Backport] magento#12396: Total Amount cart rule without tax (by @eduard13)
 - magento#21543: [BP] static tests forbid or instead of 21062 (by @novikor)


Fixed GitHub Issues:
 - magento#21510: Can't access backend indexers page after creating a custom index (reported by @ccasciotti) has been fixed in magento#21576 by @ccasciotti in 2.2-develop branch
   Related commits:
     1. 2c956f6
     2. d5ed9e8

 - magento#12396: "Total Amount" cart rule without tax (reported by @Chei20) has been fixed in magento#21845 by @eduard13 in 2.2-develop branch
   Related commits:
     1. 9529d31
     2. 362bbf2
     3. a5608f0

 - magento#21062: Static tests: forbid 'or' instead of '||' (reported by @novikor) has been fixed in magento#21543 by @novikor in 2.2-develop branch
   Related commits:
     1. 9f0ef59